Re: FYI: escape shell meta-chars in tag variable comments [libtool--release--2.0--patch-10]

[Ralf Wildenhues]

* Gary V. Vaughan wrote on Thu, Oct 07, 2004 at 04:19:30AM CEST:
> 
>   from  Gary V. Vaughan  <address@hidden>
>   
>       * m4/libtool.m4 (_LT_FORMAT_COMMENT): Shell meta-characters in
>       _LT_DECL descriptions were not being escaped before injection into
>       TAG CONFIG here documents in config.status.
>   
>   --- orig/m4/libtool.m4
>   +++ mod/m4/libtool.m4
>   @@ -261,7 +261,8 @@
>    # full-stop to the whole comment if one is not present already.
>    m4_define([_LT_FORMAT_COMMENT],
>    [m4_ifval([$1], [
>   -m4_bpatsubst([$1], [^ *], [# ])]m4_bmatch([$1], [[!?.]$], [], [.])
>   +m4_bpatsubst([m4_bpatsubst([$1], [^ *], [# ])],
>   +              [['`$\]], [\\\&])]m4_bmatch([$1], [[!?.]$], [], [.])
>    )])
>    
>    

This patch (which you also applied to HEAD) breaks my not-yet committed
.la file checking within libltdl, because it causes lines like

relink_command="(cd /tmp/build/tests/mdemo; /bin/sh 
/tmp/build/tests/mdemo/libtool  --tag
CC --mode=relink gcc -g -O2 -o libfoo2.la -rpath /tmp/build/tests/_inst/lib 
-no-undefined -module -export-symbols-regex \"libfoo2.*\" foo2.lo -lm libsub.la 
@inst_prefix_dir@)"

to be created.  The thing which I don't like here is the
  var="stuff with \" inside"
part.  Do we have to do it like this?  Did released versions of Libtool
also create lines like this (i.e., do we have to support it anyway)?

I really don't want to commit anything that causes known test failures.

Regards,
Ralf