libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: libtool--devo--1.0--patch-174


From: Gary V . Vaughan
Subject: Re: FYI: libtool--devo--1.0--patch-174
Date: Mon, 13 Sep 2004 10:20:22 +0100

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hallo Ralf,

On 13 Sep 2004, at 08:23, Ralf Wildenhues wrote:

* Gary V. Vaughan wrote on Sat, Sep 11, 2004 at 02:51:32AM CEST:

Applied to HEAD.

Index: Changelog
from  Ralf Wildenhues  <address@hidden>

        * m4/libtool.m4 (_LT_CMD_GLOBAL_SYMBOLS): The linker distinguishes
        data and code symbols on linux-gnu/ia64.  Fixes multiple testsuite
        failures.
        * NEWS: Updated.

This was not my patch.  At least not exactly.

My fault, time was very short last week and I applied your patch (badly) by hand. Thanks for catching it. Hopefully now fixed :-/

Actually, a couple of comments: I don't know why global_symbol_pipe
writes the same name twice into .libs/file.nm.  Consequently, I don't
know why the other "special" ia64 systems use the second name rather
than the first.

First one is the internal name (with a `_' prefix on some systems), and the second one is the symbol name passed to lt_dlsym (always without a prefix).

I don't know either why libtool does not just differentiate between data
and function objects on *every* system with respect to
func_generate_dlsyms, as it does not seem like much more overhead, and
at the same time would make for less special code.  But I understand
that such a change might not be suitable before a release.

That's just the way it has evolved. This release is as much about refactoring and tidying libtool to ease the maintenance burden as it is about any new features (although we have those too). I'm planning another alpha by the end of the week if I have time to fix the mkdir_p issues, and we may need another after that if Scott and Alexandre resolve to change the way linux uses pass_all or file. If you want to submit a patch before that, I'd be inclined to accept now rather than wait for the next full release.

Cheers,
        Gary.
- --
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (Darwin)

iD8DBQFBRWZZFRMICSmD1gYRArgEAJ9A3oux6IPXBMhUkp7d0QR4CHLfVQCgpSJp
SE+jU28mOuKREdqEKjjiuoQ=
=eLt1
-----END PGP SIGNATURE-----





reply via email to

[Prev in Thread] Current Thread [Next in Thread]