Re: Remove object files from convenience library after relink

[Scott James Remnant]

On Sun, 2004-03-14 at 21:12, Albert Chin wrote:
> On Fri, Feb 13, 2004 at 12:31:16PM -0600, Albert Chin wrote:
> > On Fri, Feb 13, 2004 at 11:02:07AM -0600, Albert Chin wrote:
> > > When a library is installed, dependent on a convenience library, and
> > > it involves relinking, the object files extracted from the convenience
> > > library are not removed after the relink. This is a problem if you
> > > build as non-root, install as root, then try to remove the build
> > > directory as non-root.
> > > 
> > > In addition, if the relink fails, we don't clean up after ourselves.
> > > 
> > > And, what's up with this:
> > >   $run eval '(cd $output_objdir && $rm ${realname}T && $mv $realname 
> > > ${realname}T && $mv "$realname"U $realname)' || exit $?
> > >   (i.e.)
> > >     $rm ${realname}T
> > >     $mv $realname ${realname}T
> > >     $mv "$realname"U $realname
> > > 
> > >   (example with KDE 3.2's libkutils)
> > >     rm -f libkutils.sl.3.0T
> > >     mv libkutils.sl.3.0 libkutils.sl.3.0T
> > >     mv -f libkutils.sl.3.0U libkutils.sl.3.0
> > > 
> > >   We should just:
> > >     $rm ${realname}T
> > >     $mv "$realname"U $realname
> > 
> > Ok, scratch that patch. Try this instead. The above is correct (though
> > it still leaves libkutils.sl.3.0T with permission of the user doing
> > the install).
> 
> Patch against HEAD.
> 
Seems reasonable, applied.

Scott
-- 
Have you ever, ever felt like this?
Had strange things happen?  Are you going round the twist?

signature.asc
Description: This is a digitally signed message part