Re: Pending release of 1.5

[Schleicher Ralph (LLI)]

Tim Van Holder wrote:

> On Wed, 2003-02-12 at 10:14, Robert Boehne wrote:
> > is not right.  The "\" before the "." is there to prevent
> > "." from being a regular expression matching any character.
> > So this should have been:
> >  $SED -e "s/${shared_ext}\..*/${shared_ext}/"
> 
> Unfortunately, since $shared_ext will be '.so' and not '\.so', the
> sed above mishandles names like libalso.so.5 (turning it into 'liba.so'
> instead of 'libalso.so')...
> For maximum robustness, $shared_ext needs to be transformed to a valid
> regex before this sed can run.

You are right.  Another flaw is that $shared_ext must not be equal to
".so" (the user can change it with the -shrext option) but the former
is required for KCC if I understand the comments correctly.

The updated patch attached to this message (a) regexp quotes $shared_ext
and (b) hardcodes ".so" into the replacement text.

-- 
Ralph

libtool-20030212.shrext.diff
Description: libtool-20030212.shrext.diff