libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch for "g++-x.x" named compilers


From: Robert Boehne
Subject: Re: patch for "g++-x.x" named compilers
Date: Sun, 27 Oct 2002 10:43:54 -0600

Bob Friesenhahn wrote:
> 
> On Thu, 24 Oct 2002, Robert Boehne wrote:
> > <SNIP>
> > Hmmm, what does this code actually do for us?
> 
> I wondered that myself.
> 
> > What would you all say to a patch that prints an
> > error if the mode isn't specified?
> 
> That would be fine by me.
> 
> Bob
> 

All right then, here it is.  This patch replaces the guessing
of operation mode with an error message, and removes the variable
default_mode as it is no longer used.

Ok to commit?

2002-10-27  Robert Boehne  <address@hidden>

        * ltmain.in: Do not try to inferr mode of operation, error out
        with an appropriate message if --mode=MODE is not specified.
Index: ChangeLog
===================================================================
RCS file: /cvsroot/libtool/libtool/ChangeLog,v
retrieving revision 1.1147
diff -u -r1.1147 ChangeLog
--- ChangeLog   25 Oct 2002 03:28:42 -0000      1.1147
+++ ChangeLog   27 Oct 2002 16:47:42 -0000
@@ -1,3 +1,8 @@
+2002-10-27  Robert Boehne  <address@hidden>
+
+       * ltmain.in: Do not try to inferr mode of operation, error out
+       with an appropriate message if --mode=MODE is not specified.
+
 2002-10-25  Gary V. Vaughan  <address@hidden>
 
        * README-alpha: Add some release not templates for inspiration and
Index: ltmain.in
===================================================================
RCS file: /cvsroot/libtool/libtool/ltmain.in,v
retrieving revision 1.306
diff -u -r1.306 ltmain.in
--- ltmain.in   25 Oct 2002 00:23:24 -0000      1.306
+++ ltmain.in   27 Oct 2002 16:47:46 -0000
@@ -58,7 +58,6 @@
 address@hidden@
 TIMESTAMP="@TIMESTAMP@"
 
-default_mode=
 help="Try \`$progname --help' for more information."
 magic="%%%MAGIC variable%%%"
 mkdir="mkdir"
@@ -103,7 +102,7 @@
 fi
 
 # Global variables.
-mode=$default_mode
+mode=
 nonopt=
 prev=
 prevopt=
@@ -266,44 +265,11 @@
 
 if test -z "$show_help"; then
 
-  # Infer the operation mode.
+  # Error out if the operation mode is not specified.
   if test -z "$mode"; then
-    case $nonopt in
-    *cc | cc* | *++ | gcc* | *-gcc* | g++* | xlc*)
-      mode=link
-      for arg
-      do
-       case $arg in
-       -c)
-          mode=compile
-          break
-          ;;
-       esac
-      done
-      ;;
-    *db | *dbx | *strace | *truss)
-      mode=execute
-      ;;
-    *install*|cp|mv)
-      mode=install
-      ;;
-    *rm)
-      mode=uninstall
-      ;;
-    *)
-      # If we have no mode, but dlfiles were specified, then do execute mode.
-      test -n "$execute_dlfiles" && mode=execute
-
-      # Just use the default operation mode.
-      if test -z "$mode"; then
-       if test -n "$nonopt"; then
-         $echo "$modename: warning: cannot infer operation mode from 
\`$nonopt'" 1>&2
-       else
-         $echo "$modename: warning: cannot infer operation mode without 
MODE-ARGS" 1>&2
-       fi
-      fi
-      ;;
-    esac
+    $echo "you must specifiy a mode with --mode=MODE" 1>&2
+    $echo "$help" 1>&2
+    exit 1
   fi
 
   # Only execute mode is allowed to have -dlopen flags.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]