Re: Simple quoting fix

[Steve Ellcey]

> I don't think this patch is correct. I think all you want to do is add
> the variables you want quoted to the section of libtool.m4 beginning
> with:

OK, here is a new patch (it does work as well as my previous patch).
I do have two questions, should DLLTOOL, OBJDUMP, and AS be included
here?  I skipped them because they are in quotes down on the lines:

| # Used on cygwin: DLL creation program.
| DLLTOOL="$DLLTOOL"
| 
| # Used on cygwin: object dumper.
| OBJDUMP="$OBJDUMP"
| 
| # Used on cygwin: assembler.
| AS="$AS"

which is why I did my earlier patch this way.

LTCC, MAGIC_CMD, and STRIP (just above this) are not quoted.

Also, I don't really know why CC and LD are handled differently then
old_CC, AR, etc in the quoting code (they are accessed via the
_LT_AC_TAGVAR macro) so I don't know if that is appropriate for LTCC,
MAGIC_CMD, or STRIP; but I don't think it is.


2002-01-14  Steve Ellcey  <address@hidden>
        * libtool.m4: Add LTCC, MAGIC_CMD, and STRIP to list of things
          that should be quoted.


--- libtool.orig/libtool.m4     Mon Jan 14 14:43:31 2002
+++ libtool/libtool.m4  Tue Jan 15 11:06:43 2002
@@ -3173,6 +3173,7 @@ if test -f "$ltmain"; then
   # careful not to overquote the AC_SUBSTed values.  We take copies of the
   # variables and quote the copies for generation of the libtool script.
   for var in echo old_CC old_CFLAGS AR AR_FLAGS RANLIB LN_S NM SHELL \
+    LTCC STRIP MAGIC_CMD \
     libname_spec library_names_spec soname_spec extract_expsyms_cmds \
     old_striplib striplib file_magic_cmd finish_cmds finish_eval \
     deplibs_check_method reload_flag reload_cmds need_locks \