Re: Simple quoting fix

[Albert Chin]

On Mon, Jan 14, 2002 at 03:59:37PM -0800, Steve Ellcey wrote:
> Well, that will teach me to send off a quick fix without testing.  My
> earlier change was fine, it doesn't break anything, but it didn't fix
> what I wanted it to fix either.
> 
> Here is another patch, with that change plus some more quoting fixes
> that really do fix the problem I had building GCC.

I don't think this patch is correct. I think all you want to do is add
the variables you want quoted to the section of libtool.m4 beginning
with:

  # Now quote all the things that may contain metacharacters while being
  # careful not to overquote the AC_SUBSTed values.  We take copies of the
  # variables and quote the copies for generation of the libtool script.
  for var in echo old_CC old_CFLAGS \
    AR AR_FLAGS CC LD LN_S NM SHELL \
    reload_flag reload_cmds wl \
    ...

> Steve Ellcey
> address@hidden
> 
> 
> 2002-01-14  Steve Ellcey  <address@hidden>
>       * libtool.m4: Put $CC,$LTCC,$MAGIC_CMD,$STRIP in quotes.
> 
> 
> --- libtool.orig/libtool.m4   Mon Jan 14 14:43:31 2002
> +++ libtool/libtool.m4        Mon Jan 14 15:53:28 2002
> @@ -152,7 +152,7 @@ test -z "$AR" && AR=ar
>  test -z "$AR_FLAGS" && AR_FLAGS=cru
>  test -z "$AS" && AS=as
>  test -z "$CC" && CC=cc
> -test -z "$LTCC" && LTCC=$CC
> +test -z "$LTCC" && LTCC="$CC"
>  test -z "$DLLTOOL" && DLLTOOL=dlltool
>  test -z "$LD" && LD=ld
>  test -z "$LN_S" && LN_S="ln -s"
> @@ -1419,7 +1419,7 @@ if test -f "$ltmain" && test -n "$tagnam
>      if test -z "$LTCC"; then
>        AC_MSG_WARN([output file `$ofile' does not look like a libtool script])
>      else
> -      AC_MSG_WARN([using `LTCC=$LTCC', extracted from `$ofile'])
> +      AC_MSG_WARN([using `LTCC="$LTCC"', extracted from `$ofile'])
>      fi
>    fi
>  
> @@ -3319,7 +3319,7 @@ AR=$lt_AR
>  AR_FLAGS=$lt_AR_FLAGS
>  
>  # A C compiler.
> -LTCC=$LTCC
> +LTCC="$LTCC"
>  
>  # A language-specific compiler.
>  CC=$lt_[]_LT_AC_TAGVAR(compiler, $1)
> @@ -3337,10 +3337,10 @@ LN_S=$lt_LN_S
>  NM=$lt_NM
>  
>  # A symbol stripping program
> -STRIP=$STRIP
> +STRIP="$STRIP"
>  
>  # Used to examine libraries when file_magic_cmd begins "file"
> -MAGIC_CMD=$MAGIC_CMD
> +MAGIC_CMD="$MAGIC_CMD"
>  
>  # Used on cygwin: DLL creation program.
>  DLLTOOL="$DLLTOOL"
> 
> _______________________________________________
> Libtool-patches mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/libtool-patches

-- 
albert chin (address@hidden)