[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] $linkopts vs. $linker_flags ?
From: |
Brad |
Subject: |
Re: [PATCH] $linkopts vs. $linker_flags ? |
Date: |
Sun, 5 Aug 2001 12:29:28 -0400 (EDT) |
Ok, since I was correct in thinking that $linkopts needed to be replaced,
here is the equivalent patch for the 1.4 branch.
// Brad
address@hidden
address@hidden
>Hi Brad,
>
>Good catch, thanks. Applied to HEAD.
>
>In the future, please send patches to address@hidden so that the
>other maintainers can also evaluate them... after all, I might be struck by
>lightning tomorrow, and then your patch would be dropped ;-)
>
>Cheers,
> Gary.
>
>On Sunday 05 August 2001 3:52 am, you wrote:
>> Tell me I'm not mistaken, I see only 3 places where $linkopts is still
>> referenced (I don't see it used in ltmain.in) ... I beleive these are
>> leftovers from back in libtool 1.3 days ? they should be changed to
>> $linker_flags ? This affects a few targets in both HEAD and 1.4.
>> This patch is against HEAD.
>>
>> // Brad
>>
>> address@hidden
>> address@hidden
--- libtool.m4.orig Sun Aug 5 12:20:00 2001
+++ libtool.m4 Sun Aug 5 12:20:15 2001
@@ -1541,7 +1541,7 @@
# FIXME: Relying on posixy $() will cause problems for
# cross-compilation, but unfortunately the echo tests do not
# yet detect zsh echo's removal of \ escapes.
- archive_cmds='$nonopt $(test .$module = .yes && echo -bundle || echo
-dynamiclib) $allow_undefined_flag -o $lib $libobjs $deplibs$linkopts
-install_name $rpath/$soname $(test -n "$verstring" -a x$verstring != x0.0 &&
echo $verstring)'
+ archive_cmds='$nonopt $(test .$module = .yes && echo -bundle || echo
-dynamiclib) $allow_undefined_flag -o $lib $libobjs $deplibs$linker_flags
-install_name $rpath/$soname $(test -n "$verstring" -a x$verstring != x0.0 &&
echo $verstring)'
# We need to add '_' to the symbols in $export_symbols first
#archive_expsym_cmds="$archive_cmds"' && strip -s $export_symbols'
hardcode_direct=yes
@@ -1616,7 +1616,7 @@
;;
newsos6)
- archive_cmds='$LD -G -h $soname -o $lib $libobjs $deplibs $linkopts'
+ archive_cmds='$LD -G -h $soname -o $lib $libobjs $deplibs $linker_flags'
hardcode_direct=yes
hardcode_libdir_flag_spec='${wl}-rpath ${wl}$libdir'
hardcode_libdir_separator=:
@@ -1719,7 +1719,7 @@
sysv4)
if test "x$host_vendor" = xsno; then
- archive_cmds='$LD -G -Bsymbolic -h $soname -o $lib $libobjs $deplibs
$linkopts'
+ archive_cmds='$LD -G -Bsymbolic -h $soname -o $lib $libobjs $deplibs
$linker_flags'
hardcode_direct=yes # is this really true???
else
archive_cmds='$LD -G -h $soname -o $lib $libobjs $deplibs $linker_flags'