Re: "Fix" strip test failure

[Andreas Jaeger]

Alexandre Oliva <address@hidden> writes:

> On May  2, 2001, Andreas Jaeger <address@hidden> wrote:
> 
> >> I'd rather have something that would save the error messages in a
> >> temporary file (or perhaps in a shell variable), and display them in
> >> case linking fails, or throw them away in case it succeeds.
> 
> > Like this?
> 
> I'm afraid not.  You've modified the code that relinks the program or
> the library at install time, but we don't need to be hide warnings at

:-(

> this point.  The relevant chunk of code is the one that evals
> relink_command a few lines below `temporary wrapper script for '...

> Will you please Cc: address@hidden when you post the revised
> patch?
> 
> Thanks in advance for pursuing this issue.

Here's the revised patch.  Alexandre, shall I add this to the binutils
archive or will you import a new version of ltmain.sh instead?

Andreas

2001-05-02  Andreas Jaeger  <address@hidden>, Andreas Schwab <address@hidden>

        * ltmain.sh (relink_command): Save output to a variable and
        display it only if relinking fails.

Index: ltmain.sh
===================================================================
RCS file: /cvs/src/src/ltmain.sh,v
retrieving revision 1.10
diff -u -r1.10 ltmain.sh
--- ltmain.sh   2001/04/20 09:28:05     1.10
+++ ltmain.sh   2001/05/03 12:31:56
@@ -4082,8 +4082,9 @@
 
     # relink executable if necessary
     if test -n \"\$relink_command\"; then
-      if (eval \$relink_command); then :
+      if relink_command_output=\`eval \$relink_command 2>&1\`; then :
       else
+        $echo \"\$relink_command_output\" >&2
        $rm \"\$progdir/\$file\"
        exit 1
       fi

-- 
 Andreas Jaeger
  SuSE Labs address@hidden
   private address@hidden
    http://www.suse.de/~aj