[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-49-gc13532a
From: |
Gary V. Vaughan |
Subject: |
Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-49-gc13532a |
Date: |
Sat, 3 Jul 2010 15:23:12 +0700 |
Hi Peter,
On 3 Jul 2010, at 15:15, Peter Rosin wrote:
> Fix typo in "Add func_append_quoted and do..."
>
> * libltdl/config/ltmain.m4sh (func_mode_compile): Use
> func_append_quoted instead of func_append.
> --- a/libltdl/config/ltmain.m4sh
> +++ b/libltdl/config/ltmain.m4sh
> @@ -710,7 +710,7 @@ func_mode_compile ()
> save_ifs="$IFS"; IFS=','
> for arg in $args; do
> IFS="$save_ifs"
> - func_append lastarg " $arg"
> + func_append_quoted lastarg " $arg"
> done
> IFS="$save_ifs"
> func_stripname ' ' '' "$lastarg"
Sorry, I should have paid more attention while haring through
last weeks email backlog. Instead I didn't give this patch
enough thought before okaying it...
func_append_quoted automatically adds an unquoted space before
the appended quoted string (so as to avoid func_quote_for_eval
inserting a quoted space, \'\ \'), so it's quite possible that
it's necessary to write:
func_append_quoted lastarg "$arg"
to avoid a latent bug with $lastarg not separating arguments
correctly when it is evaled later.
In an ideal world, we'd have test coverage of this part of the
code, and I would never have made the bogus commit in the
first place :(
I'm going to be too busy to tackle this for a week or so. I've
added it to my TODO list, but if you want to make the edit,
test and push, I'll tackle trying to write a test in due
course... otherwise I'll get to it myself in about a week.
Cheers,
--
Gary V. Vaughan (address@hidden)