Re: [Libjit] [PATCH 2/3] Don't use Win32 API on Cygwin

[Ken Brown]

On 8/28/2018 4:30 AM, Eli Zaretskii wrote:
> > From: Ken Brown <address@hidden>
> > Date: Mon, 27 Aug 2018 16:27:20 -0400
> >
> > Cygwin is no longer being used to create a native Windows build.  Use
> > the Posix API instead of the Win32 API to build libjit for Cygwin.
> > --- a/jit/jit-config.h
> > +++ b/jit/jit-config.h
> > @@ -28,12 +28,8 @@
> >   /*
> >    * Determine what kind of system we are running on.
> >    */
> > -#if defined(__CYGWIN__) || defined(__CYGWIN32__)
> > -# define JIT_WIN32_CYGWIN      1
> > -# define JIT_WIN32_PLATFORM    1
> > -#elif defined(_WIN32) || defined(WIN32)
> > +#if defined(_WIN32) || defined(WIN32)
> >   # define JIT_WIN32_NATIVE     1
> > -# define JIT_WIN32_PLATFORM    1
> >   #elif defined(__APPLE__) && defined(__MACH__)
>
> Does this mean Cygwin no longer defines _WIN32 and WIN32?  I think
> older versions of Cygwin did, at least Gnulib, I think, still assumes
> Cygwin does.

I think Cygwin used to define _WIN32 when the -mno-cygwin option was 
used.  Now that that option is no longer supported, I'm not aware of any 
situation in which _WIN32 or WIN32 would be defined on Cygwin.

I've often wondered why Gnulib still assumes that _WIN32 could be 
defined on Cygwin, but maybe they just want to support old versions.

Ken