Re: [Libcdio-devel] [PATCH] iso9660: Fixing off by one error in rock.c

[Rocky Bernstein]

On Thu, Oct 20, 2022 at 4:12 PM Seija Kijin <doremylover456@gmail.com>
wrote:

>
> buffer, when it should be the 10th.
> ---
>  lib/iso9660/rock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/iso9660/rock.c b/lib/iso9660/rock.c
> index a957d785..5b6e67d9 100644
> --- a/lib/iso9660/rock.c
> +++ b/lib/iso9660/rock.c
> @@ -471,7 +471,7 @@ iso9660_get_rock_attr_str(posix_mode_t st_mode)
>    result[ 8] = (st_mode & ISO_ROCK_IWOTH) ? 'w' : '-';
>    result[ 9] = (st_mode & ISO_ROCK_IXOTH) ? 'x' : '-';
>
> -  result[11] = '\0';
> +  result[10] = '\0';
>
>    return result;
>  }
>
>
Thanks and sorry for the delay. The patch has been applied in
commit 9c7d1476e2ba34e77d5e00032dec36cc6f9f025f but please double check.

BTW while the patch is right, the description was off by one: The NULL
termination was written to the *12th* element of the result (not 11th),
when it *should *have been written to the 11th.
result[10] is the 11th element since the array is 0 based.

Again, thanks.