Re: [Libcdio-devel] Proposal for fix of cd-info on MSWindows driver

[Rocky Bernstein]

On Wed, May 20, 2020 at 5:18 PM Thomas Schmitt <address@hidden> wrote:

> Hi,
>
> Pete Batard wrote:
> > Since it's your patch, I'll let you push it to master.
>
> Rocky once instructed me to make candidate branches for such occasions.
> It's too late in the night to try new tricks. :))
>
> Pete, if you can checkout branch "win32_first_tno_fix" (*) then it would
> be nice to get a confirmation that i got my version of win32.c on the
> second try by copy+paste of your corrected code.
> (First commit of the branch was my faulty proposal by mistake. Hrmpf.)
>
> After successful test, the branch would be ready for merging.
>
> --------------------------------------------------------------------------
> (*) I hope i did it right. The online git does not show my new branch,
>     though.
>
> I exercised my libcdio-on-git cheat sheet:
>
>   new_branch_name=win32_first_tno_fix
>   git checkout master
>   git pull
>   git checkout -B $new_branch_name
>
> Made change to win32.c.
>
>   git add lib/driver/MSWindows/win32.c
>   git commit -m 'Fixed win32 implementation of .get_track_msf() for CD
> with first track number > 1'
>
> Commit id is a42d093.
>
>   git push --set-upstream origin $new_branch_name
>
> Then i realized my mistake and copied the tested code from Pete's mail.
>
>   git add lib/driver/MSWindows/win32.c
>   git commit -m "Applied Pete Batard's corrections to previous commit"
>   git push
>
> Commit id is c3a8f8a.
>
> I see the new branch by
>
>   git branch -a
>
> as
>
>   * win32_first_tno_fix
>     ...
>     remotes/origin/win32_first_tno_fix
>
> But nothing is to see at
>
>   http://git.savannah.gnu.org/cgit/libcdio.git/log/



That's because this is a log of the master branch. Your change is indeed
there:

 http://git.savannah.gnu.org/cgit/libcdio.git/log/?h=win32_first_tno_fix

Get's some rest. I am sure in the morning this will be perfectly clear.
Thanks for all the help.



>
> ---------------------------------------------------------------------
>
> Have a nice day :)
>
> Thomas
>
>
>