[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libcdio-devel] [RFC] New API iso9660_statv2_t as API/ABI compatible
From: |
Rocky Bernstein |
Subject: |
Re: [Libcdio-devel] [RFC] New API iso9660_statv2_t as API/ABI compatible way to read files >= 4 GiB |
Date: |
Tue, 10 Jul 2018 05:54:18 -0400 |
Make it easy for me to help you. When I write create a branch I mean create
a branch, not more verbiage how to change a branch.
On Tue, Jul 10, 2018 at 5:38 AM, Thomas Schmitt <address@hidden> wrote:
> Hi,
>
> Rocky Bernstein wrote:
> > create a branch and commit to that and let me know the name of the
> branch.
>
> The current unsatisfying solution is in branch ts-multiextent.
>
> In lib/iso9660/iso9660_fs.c you will find at line 155 ff:
>
> /* >>> Find a better place to declare these functions.
> Implemented in lib/iso9660/rock.c
> */
> bool iso9660_rock_statbuf_clone_entrails(iso_rock_statbuf_t *target,
> iso_rock_statbuf_t *source);
> bool iso9660_rock_statbuf_init(iso_rock_statbuf_t *target);
> void iso9660_rock_statbuf_free_entrails(iso_rock_statbuf_t *target);
>
> and in lib/iso9660/rock.c at line 665 ff:
>
> /* >>> where to put these internal declarations for iso9660_fs.c ? */
> bool iso9660_rock_statbuf_clone_entrails(iso_rock_statbuf_t *target,
> iso_rock_statbuf_t *source);
>
> bool iso9660_rock_statbuf_init(iso_rock_statbuf_t *target);
>
> void iso9660_rock_statbuf_free_entrails(iso_rock_statbuf_t *target);
>
> If i remove these and put the three declarations to the end of
> lib/iso9660/iso9660_private.h like this:
>
> /* Interface of rock.c to be called by iso9660_fs.c */
> bool iso9660_rock_statbuf_clone_entrails(iso_rock_statbuf_t *target,
> iso_rock_statbuf_t *source);
> bool iso9660_rock_statbuf_init(iso_rock_statbuf_t *target);
> void iso9660_rock_statbuf_free_entrails(iso_rock_statbuf_t *target);
>
> (directly before #endif /* CDIO_ISO0660_ISO9660_PRIVATE_H_ */ ),
> then i get the complaint
>
> In file included from iso9660.c:28:0:
> iso9660_private.h:81:42: error: unknown type name 'iso_rock_statbuf_t'
>
> which i can only make worse by including libcdio header files in
> iso9660_private.h.
>
>
> Have a nice day :)
>
> Thomas
>
>
>
Re: [Libcdio-devel] [RFC] New API iso9660_statv2_t as API/ABI compatible way to read files >= 4 GiB, Thomas Schmitt, 2018/07/10
- Re: [Libcdio-devel] [RFC] New API iso9660_statv2_t as API/ABI compatible way to read files >= 4 GiB,
Rocky Bernstein <=
Re: [Libcdio-devel] [RFC] New API iso9660_statv2_t as API/ABI compatible way to read files >= 4 GiB, Thomas Schmitt, 2018/07/12
Re: [Libcdio-devel] [RFC] New API iso9660_statv2_t as API/ABI compatible way to read files >= 4 GiB, Thomas Schmitt, 2018/07/12