Re: [Libcdio-devel] RFC: Support for non-POSIX systems?

[Leon Merten Lohse]

I am sorry, I really misunderstood you.

If this is "only" about whether to support non-POSIX build systems this 
whole discussion is getting pretty hypothetical.

I mean, just because some MSVC developers might send in some bad patches 
we do not need to lock them out all together.

Would there be any other effect on the actual source code than some 
extra macros in the headers and even more ugly code in the win32 directory?

Concerning the version.h. I understand Rocky's objections to have it in 
git. If it is just that one file, imho a MSVC developer can easily add 
it by hand. I mean. It is *one* file with a handful of constants. Just 
mention it in the to be written guide and provide a fast way to 
determine the current version.

From my point of view, an additional MSVC project file does not harm 
either.

As for the testing. As Rocky mentioned, there are lots of C-tests 
available. You don't even have to run all of them. Most of the time you 
only change one aspect of the library. If you run the tests for that 
aspect you can be pretty sure you did not break anything.
Also you can and should always feed some test images to cd-info and 
compare the output. It is not as easy as doing automated tests but 
something one can expect.

If we encounter massive broken patches from MSVC people, you can still 
pull the emergency brake and refuse all patches not tested on a POSIX 
system.

Please correct me, if I missed something.

Regards
Leon