[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libcdio-devel] [PATCH] UDF+ISO image extraction sample (and a plan

From: Pete Batard
Subject: Re: [Libcdio-devel] [PATCH] UDF+ISO image extraction sample (and a plan for upcoming changes)
Date: Tue, 24 Jan 2012 11:10:35 +0000
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1

On 2012.01.24 03:50, Rocky Bernstein wrote:
This was  what commit 462b417e was about. To get a failing test for this
all I had to do was create a UDF with two files (README and COPYING from
libcdio) using the command:

      mkisofs -R -J -udf -iso-level 3 -o /tmp/test-udf1.iso /tmp/udf-test1

Which adds less than 900k to the untarred distribution.

Sounds good to me. Thanks.

- at least one file with extended attributes and allocated descriptors that
result in a File Entry that is greater in size than the last one used. I'm
not exactly sure how the reuse is supposed to occur, and since it doesn't
matter with my proposed fix, I haven't investigated, but this may be linked
to the next test below, as the problem manifests itself with files that are
larger than 1 GB apparently

When there is a specific patch for this, I'll start on a test. Otherwise,
I'd not be sure I would be creating the problem you are seeing.

OK. I'll start pushing proposed patches directly in -pbatard then.

I am committing only to testing bugs encountered that are you are fixing,
not bugs one can imagine encountering but haven't encountered.  Others who
are more interested in UDF support are welcome to add suggest other tests.
More below...

Fair enough.

Adding 2GB to the distribution for testing everyone gets is not acceptable.
Thus either the images need to be stored someplace where folks can download
them. Or have a way to create suitable images on the fly.  Either way,
probably something for a little later.


Additionally, having some filenames in CJK for instance, to test/implement
Unicode preservation would be welcome (I assume most of us will be testing
with a Western locale).

Is this something that has been observed as being a bug?

No. I expect it to work, but I haven't had a chance to test it yet. I was just wondering how much you wanted the test image(s) to cover, and this seemed simple enough to add.

I didn't say this as part of the TDD/BDD thing, but part of the "Agile
programming" philosophy is starting out with what you need right now, not
what you imagine you might need. Of course, it is also useful to try not to
code oneself in a corner.

Understood. Thanks for the c1ea555d commit.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]