libcdio-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libcdio-devel] [PATCH] buffer overflow and fixes from static analys


From: Robert William Fuller
Subject: Re: [Libcdio-devel] [PATCH] buffer overflow and fixes from static analysis
Date: Thu, 02 Jun 2011 17:15:20 -0400
User-agent: Thunderbird 2.0.0.23 (X11/20100708)

Hi,

Was the sprintf patch applied?  Some of the lines, such as this one:

+      snprintf(volpath, 256, "%s/s0", globbuf.gl_pathv[i]);

Should probably be like this instead:

+      snprintf(volpath, sizeof(volpath), "%s/s0", globbuf.gl_pathv[i]);

But, that is just my opinion....  I am not a fan of redundancy.

Thoughts?  Thank you!

Rob



reply via email to

[Prev in Thread] Current Thread [Next in Thread]