libcdio-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Libcdio-devel] Re: here's a patch that changes nothing...


From: Robert William Fuller
Subject: [Libcdio-devel] Re: here's a patch that changes nothing...
Date: Sat, 08 Mar 2008 23:12:28 -0500
User-agent: Thunderbird 2.0.0.6 (X11/20071013)

Robert William Fuller wrote:
Robert William Fuller wrote:
Robert William Fuller wrote:
Robert William Fuller wrote:
Robert William Fuller wrote:
Robert William Fuller wrote:
This is preliminary work for adding support for audio track pregaps in NRG images. It does not change existing behavior, but it does add necessary fields to the daox and daoi structures. Let me know what you think. I'm assuming I should hold on to these until after the freeze?

Scratch that. I just realized I can delete code from nrg.c! Another patch will follow.

Sheesh, why make common structures if you don't delete code? Ok, so here's the revised version:

Aw crap. I'll never get this right. Here's the same patch with the "Only in" removed:

Looks like I missed that extra +1 for CDIO_MCN_SIZE too.... O well, when I submit something larger? The funny thing is that CDIO_MCN_SIZE is 13, so the macro already includes the NULL terminator, but there's lots of code that allocates CDIO_MCN_SIZE+1 then does [CDIO_MCN_SIZE]='\0';

Okay so I truly am on crack. That's what I get for trusting wikipedia.... It's got the MCN as 12 bytes, when it is really 13. Bleck. I'll deal with this and fix this later. Please disregard all patches :-p





reply via email to

[Prev in Thread] Current Thread [Next in Thread]