Re: [Libcdio-devel] Eject

[R. Bernstein]

address@hidden writes:
 > Hi,
 > 
 > patch committed. 

Many thanks. (I made a small change subsequently to change an "int" to
a "bool" and made note of the eject fixes work in NEWS.)


 > Also added cdio-eject.c to the example directory.
 > I noticed, that we have 2 eject commands now :)

The other eject (open the drive door and close it) which I guess is a
not the best name, I used more as a canned test program and a program
to try to show off some of the error handling. 

cdio-eject seems more like a stripped-down command utility. Aside from
the similar names, I don't see a problem with having lots of
examples. I've updated the README in that directory though to try to
indicate what each is about. Feel free to correct what I've written.

 > 
 > > A fix for this I think would be to issue either and info or warning
 > > message that the tray door is open. If folks have an opinion on which,
 > > let me know. Also whether the return should be DRIVER_OP_SUCCESS or some
 > > other value. (We could even add a new code for something like NO_OP, but
 > > that mean breaking the ABI.)
 > 
 > >From the applications point of view, it is not really an error. So I would
 > return DRIVER_OP_SUCCESS and maybe a warning message.
 > 
 > The standard linux eject command does nothing and exits with zero return
 > code in this case.

Okay. Thanks for the info. Just changed so that it returns
DRIVER_OP_SUCCESS and doesn't erroneously close the door. Given that
eject doesn't say anything, I've set the level to "info" rather than
"warning", so an application that does want to show this can, but it's
not shown by default as warnings generally are (I think).