libcdio-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Libcdio-devel] Regression tests


From: R. Bernstein
Subject: [Libcdio-devel] Regression tests
Date: Fri, 2 Jun 2006 20:16:33 -0400

My bad. In short, I've just committed changes to fix this.

When I first started this and created the test ISO, I thought I'd use
a file that was otherwise around in libcdio, unchanging, and for which
there would be no ambiguity of whether it was proprietary or not. I
hadn't imagined that COPYING in fact is not unchanging. I think the
address in fact changed more than once.

For people who build from tarballs it never was a problem because they
get the version that I have on my disk at home and I've arranged it
not to use a symlinked copy that autotools will put in by default. So
only has been a problem for those people who compile from CVS and use
a newer version of autotools. This problem has been around for a
while, maybe 6 months to a year. So the surprising thing is not that
it's broken but no one (other than me) noticed it.

address@hidden writes:
 > Hi again,
 > 
 > while playing with regression tests:
 > 
 > ../check_iso.sh: iso-info basic test ok.
 > --- copying     2006-06-02 22:04:59.000000000 +0000
 > +++ ./../COPYING        2005-04-14 05:08:53.000000000 +0000
 > @@ -2,7 +2,7 @@
 >                        Version 2, June 1991
 > 
 >   Copyright (C) 1989, 1991 Free Software Foundation, Inc.
 > -     51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 > +     59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 >   Everyone is permitted to copy and distribute verbatim copies
 >   of this license document, but changing it is not allowed.
 > 
 > @@ -305,7 +305,7 @@
 > 
 >      You should have received a copy of the GNU General Public License
 >      along with this program; if not, write to the Free Software
 > -    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
 > 02110-1301 USA
 > +    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 
 > USA
 > 
 > 
 >  Also add information on how to contact you by electronic and paper mail.
 > ../check_iso.sh: iso-read basic test failed in comparing output.
 > ../check_iso.sh: failed command:
 >         ../src/iso-read --image ./copying.iso --extract copying
 > FAIL: check_iso.sh
 > 
 > Can it be that the regression tests fail, because a file in an ISO image
 > has the old FSF address? :))
 > 
 > Burkhard
 > 
 > 
 > 
 > 
 > _______________________________________________
 > Libcdio-devel mailing list
 > address@hidden
 > http://lists.gnu.org/mailman/listinfo/libcdio-devel
 > 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]