[Koha-cvs] koha/C4 Biblio.pm [dev_week]

[Cindy Murdock]

CVSROOT:        /sources/koha
Module name:    koha
Branch:         dev_week
Changes by:     Cindy Murdock <clm>     07/11/20 18:31:29

Modified files:
        C4             : Biblio.pm 

Log message:
        Fixed sub _koha_modify_item so that changes to itemnotes & itemlost are 
actually saved.
        Also removed update to biblioitemnumber, since it seemed to be 
inserting '0' into biblioitemnumber
        on editing an item instead of the actual bibitemnum.  I don't think 
it's necessary to rewrite
        that while we're just modifying item level data anyway.  
        
        Should $item->{bibitemnum} really be $item->{biblioitemnumber}?  I 
tried changing that, but
        it didn't seem to fix biblioitemnumber being set to 0, so I left it 
untouched.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/koha/C4/Biblio.pm?cvsroot=koha&only_with_tag=dev_week&r1=1.115.2.51.2.45&r2=1.115.2.51.2.46

Patches:
Index: Biblio.pm
===================================================================
RCS file: /sources/koha/koha/C4/Biblio.pm,v
retrieving revision 1.115.2.51.2.45
retrieving revision 1.115.2.51.2.46
diff -u -b -r1.115.2.51.2.45 -r1.115.2.51.2.46
--- Biblio.pm   20 Nov 2007 15:02:37 -0000      1.115.2.51.2.45
+++ Biblio.pm   20 Nov 2007 18:31:28 -0000      1.115.2.51.2.46
@@ -2104,20 +2104,20 @@
 
barcode=?,itemnotes=?,itemcallnumber=?,notforloan=?,location=?,multivolumepart=?,multivolume=?,stack=?,wthdrawn=?,holdingbranch=?,homebranch=?,cutterextra=?,
 onloan=?, binding=?,price=?,replacementprice=?";
 
     my @bind = (
-        $item->{'barcode'},                    $item->{'notes'},
+        $item->{'barcode'},                    $item->{'itemnotes'},
         $item->{'itemcallnumber'},     $item->{'notforloan'},
         $item->{'location'},           $item->{'multivolumepart'},
                $item->{'multivolume'},         $item->{'stack'},
                
$item->{'wthdrawn'},$item->{'holdingbranch'},$item->{'homebranch'},$cutterextra,$item->{'onloan'},$item->{'binding'},$item->{'price'},$item{'replacementprice'}
     );
-    if ( $item->{'lost'} ne '' ) {
-        $query = "update items set 
biblioitemnumber=?,barcode=?,itemnotes=?,homebranch=?,
+    if ( $item->{'itemlost'} ne '' | '0' ) {
+        $query = "update items set barcode=?,itemnotes=?,homebranch=?,
                                                        
itemlost=?,wthdrawn=?,itemcallnumber=?,notforloan=?,
                                                        
location=?,multivolumepart=?,multivolume=?,stack=?,wthdrawn=?,holdingbranch=?,cutterextra=?,onloan=?,
 binding=?,price=?,replacementprice=?";
         @bind = (
             $item->{'bibitemnum'},     $item->{'barcode'},
-            $item->{'notes'},          $item->{'homebranch'},
-            $item->{'lost'},           $item->{'wthdrawn'},
+            $item->{'itemnotes'},          $item->{'homebranch'},
+            $item->{'itemlost'},           $item->{'wthdrawn'},
             $item->{'itemcallnumber'}, $item->{'notforloan'},
             $item->{'location'},               $item->{'multivolumepart'},
                        $item->{'multivolume'},         $item->{'stack'},
@@ -3158,8 +3158,17 @@
 
 =cut
 
-# $Id: Biblio.pm,v 1.115.2.51.2.45 2007/11/20 15:02:37 clm Exp $
+# $Id: Biblio.pm,v 1.115.2.51.2.46 2007/11/20 18:31:28 clm Exp $
 # $Log: Biblio.pm,v $
+# Revision 1.115.2.51.2.46  2007/11/20 18:31:28  clm
+# Fixed sub _koha_modify_item so that changes to itemnotes & itemlost are 
actually saved.
+# Also removed update to biblioitemnumber, since it seemed to be inserting '0' 
into biblioitemnumber
+# on editing an item instead of the actual bibitemnum.  I don't think it's 
necessary to rewrite
+# that while we're just modifying item level data anyway.
+#
+# Should $item->{bibitemnum} really be $item->{biblioitemnumber}?  I tried 
changing that, but
+# it didn't seem to fix biblioitemnumber being set to 0, so I left it 
untouched.
+#
 # Revision 1.115.2.51.2.45  2007/11/20 15:02:37  clm
 # Changed line 961 to update deletedbiblioitems instead of deleteditems;
 # it was trying to write to the 'marc' field, which doesn't exist in 
deleteditems