Re: Problems with Trigger Scripts and CVS Pre-Commit Hooks

[Traiano Welcome]

Arthur Barret,

---
Concurrent Versions System (CVS) 1.11.5-FreeBSD (client/server)
---

O.S:

---
6.2-STABLE FreeBSD 6.2-STABLE #0: Sun Feb 18 15:18:46 SAST 2007
---

$CVSROOT (I think you mean:) ...:

----
 /home/cvsroot/named.data/ZONES/
---

Thanks in Advance,
Traiano

On 2010/07/27 2:24 PM, "Arthur Barrett" <address@hidden> wrote:

Traiano Welcome,

Which version of CVS?  Eg: 1.12.1 server and 1.11.1 client

What connection string (sometimes called $CVSROOT), eg:
:pserver:host:/repo

Which operating system? Eg: Red hat Entperprise Linux 5u4 server, sun
solaris sparc 9 client

Regards,


Arthur

> -----Original Message-----
> From:
> address@hidden
> [mailto:address@hidden
> org] On Behalf Of Traiano Welcome
> Sent: Saturday, 24 July 2010 7:51 PM
> To: address@hidden
> Subject: Problems with Trigger Scripts and CVS Pre-Commit Hooks
>
>
> Hi List
>
> I use cvs to manage BIND9 DNS zone files, and would like to create a
> pre-commit hook that will run a syntax checker on the zone
> file before it's
> committed. To do this, I have a shell wrapper that takes the
> name of the
> zone file as an argument and formats a command for the syntax
> checker. The
> shell wrapper is called from the commitinfo file as follows:
>
> ---
> named.data/ZONES/* /usr/local/bin/checkzone %s
> ---
>
> And "%s" is supposed to be expanded to the name of the zone
> file when any
> file under " named.data/ZONES/" is committed. The checkzone
> script is as
> follows:
>
> ---
> #!/bin/sh -x
> ZONE=`echo $1 | cut -d "." -f  2,3,4,5,6`
> ZONE_FILE=DB.$ZONE
> named-checkzone $ZONE $ZONE_FILE
> ---
>
> However, when I run the commit, the debug information shows the "%s"
> variable is not being expanded to the name of the file,
> consequently the
> shell script does not get the correct argument and the commit fails:
>
> ---
> address@hidden ~/named.data/ZONES]$ cvs commit  DB.evasive.co.za
>
> + cut -d . -f 2,3,4,5,6
> + echo %s
> + ZONE=%s
> + ZONE_FILE=DB.%s
> + named-checkzone %s DB.%s
>
> zone %s/IN: loading from master file DB.%s failed: file not found
>
> cvs commit: Pre-commit check failed
> cvs [commit aborted]: correct above errors first!
>
> ---
>
>
> Please could someone help me shed some light on this for me?
> I suspect it's
> somehow related to the environment the script is being run in, but the
> details escape me, and why "%s" is not being expanded is also
> beyond me at
> the moment :-P
>
> Thanks in Advance,
> Traiano Welcome
>
>
>
>
>
>
>
> NOTE: This e-mail message and all attachments thereto contain
> confidential information intended for a specific addressee
> and purpose. If you are not the addressee (a) you may not
> disclose, copy, distribute or take any action based on the
> contents hereof; (b) kindly inform the sender immediately and
> destroy all copies hereof. Any copying, publication or
> disclosure of this message, or part hereof, in any form
> whatsoever, without the sender's express written consent, is
> prohibited. No opinion expressed or implied by the sender
> necessarily constitutes the opinion of MTN. This message does
> not constitute a guarantee or proof of the facts mentioned
> herein. No Employee or intermediary is authorised to conclude
> a binding agreement on behalf of MTN Group Limited, or any of
> its subsidiary companies, by e-mail without the express
> written confirmation by a duly authorised representative of
> MTN Group Limited.
>
>


________________________________
NOTE: This e-mail message and all attachments thereto contain confidential 
information intended for a specific addressee and purpose. If you are not the 
addressee (a) you may not disclose, copy, distribute or take any action based 
on the contents hereof; (b) kindly inform the sender immediately and destroy 
all copies hereof. Any copying, publication or disclosure of this message, or 
part hereof, in any form whatsoever, without the sender's express written 
consent, is prohibited. No opinion expressed or implied by the sender 
necessarily constitutes the opinion of MTN. This message does not constitute a 
guarantee or proof of the facts mentioned herein. No Employee or intermediary 
is authorised to conclude a binding agreement on behalf of MTN Group Limited, 
or any of its subsidiary companies, by e-mail without the express written 
confirmation by a duly authorised representative of MTN Group Limited.