Re: mechanisms for reviews needed

[Todd Denniston]

Jacob wrote:
> 
> Andy Jones wrote:
> > It seems to me that it's all about what the repository actually +is+.
> >
> > Jacob would like the repository to contain only tested code, ready for
> > release - if I understand correctly.
> 
> No, you misunderstand. This has not to do with unstable vs. stable
> or development vs. production code.
> 
> I am simply asking for an (optional) review step to prevent the
> repository being poluted with crap code. What this review will
> contain (nothing, manual review, style check, unit testing,
> function test, ...) must be decided by the organization. Typical
> it will vary based on the current phase of the project;
> For a system already in beta test I'd be very strict on what to
> let in. For a prototype mock-up just started I'd be more lenient.
> 
> You may claim none of this belong in a VCS and I agree in principle.
> Problem is that the system that should take care of this *outside*
> the VCS must be so tightly integrated with the VCS that it would be
> simpler just to define it as part of it.

For some of my projects, I have defined a rcsinfo/verifymsg set that
requires feed back about the review process that the developers are supposed
to go through prior to commit. The verifymsg script can be set to query (and
update if necessary) databases and file systems as necessary to make sure
state machines and review artifacts are as they are defined by policy to be.

But as someone else mentioned this is a management problem, and you need a
management solution, however by using rcsinfo/verifymsg/commitinfo you can
design and implement a technological helper for management's solution that
actually matches YOUR management's desire. CVS does not force _A_ solution
or practice on you, but it does require that you spend the time to implement
exactly what you need, when what you need happens to be management
procedures (to match policy).  If you believe that you have come up with a
solution that others might find useful, the source does come with a contrib
directory that you could contribute to.

-- 
Todd Denniston
Crane Division, Naval Surface Warfare Center (NSWC Crane) 
Harnessing the Power of Technology for the Warfighter