Re: acl for cvs, access from internal machines

[Mark D. Baushke]

Edward Peschko <address@hidden> writes:

> ok... I used gcc-2.95.3 as a back-check (as well 
> as /opt/SUNWspro/bin/cc) do you have a K&R compiler I could
> check it out on?

A SunOS 4.x system would work for that if you have one handy.
The other possibility is to run your code thru one of the ansi2knr
programs...

> > Many function calls are missing the space before the parenthesis entirely.
> > Some lines are a lot longer than eighty columns without a real need for
> > them to be.
> 
> That's my fault, my environment has exceedingly small type, and is 
> greater than 80 characters because I do a lot of data work. Maybe
> I should have a devel window and a work window - except that I'm
> on windows 2000, using 'screen' to a solaris workstation, and hence
> don't have virtual desktops. :-<

As has been mentioned, the maximum length is just advisory. I believe
that add.c and buffer.h both have some lines that are at the 132
character width. I was mostly noting that it didn't match the style
of most of the other cvs source files around it.

> > You also have not provided ChangeLog entires that describe what has
> > changed.
> 
> true, true. like I said, the main point of the patch was to float out
> an idea (albeit a *usable* idea ) and work on the niceties later. 
> Considering I didn't know what the niceties were...

Agreed. Floating and idea with working code on the info-cvs list is a
good way to get folks to take a look at what you have and see if they
want to get behind your new feature and support it.

        Thanks,
        -- Mark