Re: cvs edit/commit problem

[Noel L Yap]

address@hidden on 2000.10.05 14:28:01
>> The purpose of "cvs edit" is to communicate to others that you
>> intend to modify and commit a file.  Therefore, unless you really do
>> intend to modify and commit all files, "cvs edit *" is the wrong
>> thing to do.  Don't do that.
>
>Ok, then take this situation. I see a problem in this file. I want to
>edit it so I type "cvs edit <file1>" Then with further investigation I
>see the problem is really in file2, so I do "cvs edit <file2>" and
>then make my changes in file2. Then I am done with editing all files
>in this directory and am ready to checkin, so I do "cvs commit"

You should've done "cvs unedit <file1>" when you found out you weren't planning
to commit it.  You can do "cvs editors" to help figure out what files you have
edited.

>Why does cvs unedit the file that was modified and not unedit the file
>that was not modified.

Because the file that was modified was checked in.  I think it would be
extremely difficult (and possibly damaging) to have "cvs ci" see files that
haven't been modified so that it can act on them.

> Doesn't this part of the interface seem brain
>damaged to anyone else?

It used to to me.  Then I came to the conclusion that "cvs ci" is meant to act
on modified files only.

> Either change all the files or none of the
>files, but this half-baked attempt at unediting some files just leads
>to problems.

I disagree.  If the user really wanted to unedit all files, they should "cvs
unedit" themselves.

Changing the current behaviour breaks CVS for those who are used to doing:
cvs edit file0
cvs edit file1
vi file0 # and modify it
cvs ci
vi file1 # and modify it
cvs ci

Noel




This communication is for informational purposes only.  It is not intended as
an offer or solicitation for the purchase or sale of any financial instrument
or as an official confirmation of any transaction. All market prices, data
and other information are not warranted as to completeness or accuracy and
are subject to change without notice. Any comments or statements made herein
do not necessarily reflect those of J.P. Morgan & Co. Incorporated, its
subsidiaries and affiliates.