Re: [Help-smalltalk] [PATCH] update cygwin path conversion api

[In-Ho Yi]

Hi,

Thanks for the response. I have amended patch to include proper email.
Also, I found that with new api, extra error check is unnecessary,
hence made the further change.

On 10 April 2014 07:19, Holger Hans Peter Freyther <address@hidden> wrote:
> On Wed, Apr 09, 2014 at 02:27:05AM -0700, In-Ho Yi wrote:
>> Hi,
>>
>> There was reference to old cygwin api that was failing the build.
>
> Hi!
>
> thanks for the patch. Could you use git config to set your email
> address to your gmail address for future commits?
>
> Could you please create a patch to update the comment around the
> code. E.g. it refers to the old method and now the new one actually
> offers a return code we could check?
>
> Would you be interested in updating that as well?
>
> thanks
>         holger

0001-update-cygwin-path-conversion-api-which-now-gives-er.patch
Description: Binary data