help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] GC Crash/Bug due recursion?


From: Gwenael Casaccio
Subject: Re: [Help-smalltalk] GC Crash/Bug due recursion?
Date: Mon, 04 Jul 2011 21:42:29 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 07/04/2011 01:40 PM, Paolo Bonzini wrote:
What I asked:

by making it accept an OOP

What you have:

--- a/libgst/oop.c
+++ b/libgst/oop.c
@@ -2242,68 +2242,89 @@ _gst_add_an_oop_to_mark_queue (OOP oop)
void
_gst_mark (void)

What I asked:

What's the difference from v1?

What you have:

Sorry it was not the good patch.

Please read messages _before_ replying to them.

Paolo

Hello,

I've made some changes:

1) I keep _gst_mark_an_oop_internal and removed _gst_add_an_oop_to_mark_queue for adding an OOP in the Queue. So like the previous one, it has an OOP has argument and visit it.

2) in _gst_mark_an_oop_internal when visiting one OOP I keep the same
behavior with TAIL_MARK_OOP, and TAIL_MARK_OOPRANGE add OOPs in the Queue.

3) _gst_mark_oop_range keeps the same behavior as the old one

The patch is tested and produced with master (all tests are green)

Gwen

Attachment: mark.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]