[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Help-gnutls] Re: Failure to import an OpenPGP private key
From: |
Simon Josefsson |
Subject: |
[Help-gnutls] Re: Failure to import an OpenPGP private key |
Date: |
Tue, 16 Jan 2007 11:14:35 +0100 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.92 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> Hi,
>
> Simon Josefsson <address@hidden> writes:
>
>> Installed in CVS now. Could you suggest the patch to fix your
>> original problem, using this new scheme?
>
> Thanks for doing it! Attached is the updated patch.
Applied.
>> I just realized a thing: I'm not sure we are really breaking the
>> API/ABI here though. No public API/ABI is modified, only internal
>> _gnutls_* APIs. The same holds for your first patch.
>
> Indeed, no _public_ ABI/API is modified. That said, the ABI _is_
> modified: one cannot use an older `libgnutls-extra' with a newer
> `libgnutls' (or vice versa). But that would have been an issue only if
> one had been allowed to use different versions of `libgnutls-extra' and
> `libgnutls' together.
Right. That has never been allowed, and I don't see the point in
permitting that. libgnutls and libgnutls-extra are tightly coupled.
> In my original message [0], I had in mind something that would implement
> a slightly higher abstraction level over certificate types, such that no
> X509/OpenPGP-specific code and no `switch (certtype)' need to appear in
> `auth_cert.c' et al. For instance, we'd move the
> `proc_{x509,openpgp}_server_certificate ()' functions to specific files,
> and instead just call
> `_gnutls_cert_vtable[certtype].process_server_certificate ()', and so on.
Yes, I think that would be nice. All the code could then do something
like:
if (_gnutls_cert_vtable[certtype])
_gnutls_cert_vtable[certtype].process_server_certificate ()
else
return GNUTLS_E_INIT_LIBEXTRA;
Would you like to propose a patch for that? I'd expect it to only
require changes to gnutls_cert.c/auth_cert.c...
/Simon
- [Help-gnutls] Re: Failure to import an OpenPGP private key, Ludovic Courtès, 2007/01/05
- [Help-gnutls] Re: Failure to import an OpenPGP private key, Simon Josefsson, 2007/01/08
- [Help-gnutls] Re: Failure to import an OpenPGP private key, Ludovic Courtès, 2007/01/09
- [Help-gnutls] Re: Failure to import an OpenPGP private key, Simon Josefsson, 2007/01/09
- [Help-gnutls] Re: Failure to import an OpenPGP private key, Ludovic Courtès, 2007/01/09
- [Help-gnutls] Re: Failure to import an OpenPGP private key, Simon Josefsson, 2007/01/11
- [Help-gnutls] Re: Failure to import an OpenPGP private key, Simon Josefsson, 2007/01/11
- [Help-gnutls] Re: Failure to import an OpenPGP private key, Ludovic Courtès, 2007/01/15
- [Help-gnutls] Re: Failure to import an OpenPGP private key,
Simon Josefsson <=
- [Help-gnutls] Re: Failure to import an OpenPGP private key, Ludovic Courtès, 2007/01/16
- [Help-gnutls] Re: Failure to import an OpenPGP private key, Simon Josefsson, 2007/01/16
[Help-gnutls] Running srp/tls from windows version of gnutls, Avasarala Ranjit-A20990, 2007/01/10