[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: problems importing keys via epa-search-keys

From: Eli Zaretskii
Subject: Re: problems importing keys via epa-search-keys
Date: Sun, 12 Mar 2023 08:33:30 +0200

> From: Filipp Gunbin <>
> Cc:
> Date: Sun, 12 Mar 2023 02:04:21 +0300
> On 11/03/2023 09:17 +0200, Eli Zaretskii wrote:
> > It's a regression that existed since Emacs 28.1, right?  So its fix
> > should try to avoid changing APIs.  Therefore, please try to make a
> > change that leaves the signature of epa-ks--query-url unchanged, I
> > think it should be easy in this case.  (Yes, I know it's an internal
> > function, but that doesn't mean we can change the signature when we
> > can avoid that.)
> Yes, since 28.1.  The updated patch is below.
> But why an internal function is part of API?  Don't we assume that
> anyone using them is doing so at their own risk?  In this case the
> default for operation is "index" (to preserve compatibility), but it's
> better here to not have the default value at all.

I agree that we can break the API if we need, but we don't need to,
and it is always better to keep the signature unless it's impossible.

So please modify your patch to leave the signature intact, I don't
think it's hard in this case.

> > P.S. And why are you posting patches and their discussion here, not on
> > the bug tracker?
> Because OP wrote here?  And we didn't open a bug for this.  Should we,
> even for such simple fixes?

It's better, because then the discussion is recorded and referenced in
the commit.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]