[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Any way to control which articles Gnus summary shows by default?

From: Michael Heerdegen
Subject: Re: Any way to control which articles Gnus summary shows by default?
Date: Mon, 09 Apr 2018 16:12:17 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Eric Abrahamsen <address@hidden> writes:

> And the solution needs to be making the process equally recursive,
> because right now it's entirely possible that other packages could start
> using eieio-persistent with weird data structures, and fall afoul of
> this asymmetry. It's not just about quotes: if another package starts
> stashing EIEIO objects inside nested hash tables, they will be written
> correctly, but read incorrectly.

I think I would make it so that what is written in the save file is an
expression that, when read _and_ evaluated, would return the recovered
object.  The approach on the object-write side would not be much
different than now, but the restoring part would be trivial, so code
changes would become less problematic.

> My next stab at a fix is in the attached patch. Michael, assuming I
> haven't exhausted your patience,

My patience here lasts as long as necessary, don't worry :-)

> would you mind giving this a try? I do believe this is the right
> solution, or at least the best minimal solution.

So far this fixes quote accumulation completely for me - Great!  I
didn't yet try to use the registry explicitly, so I can't say whether
your fix works correctly.  Anyway - thanks so far!

FWIW, when I read the sources, I got the impression that all conses are
handled as if they were true lists.  Trying to save conses whose cdr is
not consp will probably error, since the current code always seems to
try to iterate over list elements.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]