help-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Scrolling jumpy when line-spacing > 0


From: Eli Zaretskii
Subject: Re: Scrolling jumpy when line-spacing > 0
Date: Sat, 22 Apr 2017 10:38:24 +0300

> From: Yuri Khan <address@hidden>
> Date: Sat, 22 Apr 2017 02:30:25 +0700
> Cc: "address@hidden" <address@hidden>
> 
> >> As a user, I’d expect that additional spacing does not count toward
> >> whether the line is considered visible.
> >
> > The Emacs display engine was designed to avoid having point in a
> > partially visible line, for whatever reasons.  The code which checks
> > for partial visibility doesn't care what is in the invisible part,
> > because checking for that would take non-trivial processing, and the
> > subtlety isn't important enough to slow down redisplay.
> 
> How come Emacs 24 lets me put point in that partially fully visible
> line? Was something simplified between 24 and master?

Not simplified, fixed.  What Emacs 24 and 25 did caused
display-related bugs in some cases, and those bugs were fixed in v26.

> To me, that kind of subtlety is important. Not that important to cry
> regression, but important enough to wonder if I could afford the
> slowdown.

You could perhaps afford the slowdown, but you (and the rest of us)
couldn't afford the bugs.

> I’m even mildly bothered by the fact that spacing is conceptually
> below its line; I’d find it nicer if half of it was above.

Patches to make spacing display like that are welcome.

> > Doesn't posn-at-point allow you to find out whether point is in the
> > topmost window line?  (Caveat: this could require special
> > consideration when there's a non-nil header-line-format in the
> > window.)
> 
> Maybe. Maybe not. On the one hand, I do have a non-nil
> header-line-format at all times. (For tabbar-mode.) On the other hand,
> when I evaluate (posn-at-point) with point in the topmost window line,
> I get zero Y and ROW values. It is not immediately clear if I can rely
> on that.

You can rely on that.  Reporting these values reliably is that
function's sole purpose, so if it doesn't, it's a bug that should be
reported.

If all you care about is whether point is in the first screen line of
the window, and if you don't need to support too old Emacs versions
(where AFAIR there was some inconsistency wrt the first line's
coordinates), then the existence of header-line is not an issue for
you, and you should have no reason to avoid that function and roll
your own, because your own code will have similar subtleties, which
posn-at-point is supposed to have solved already.

> On the third hand, using motion relative to the point is immediately
> clear. What’s the downside? Is it going to be slow? Slow enough to be
> noticeable at a key repeat rate of 40 Hz?

The main downside is that you might expose the motion to the user
under some circumstances, like C-g or some position-related hooks.  It
is also slower, yes (because posn-at-point is implemented entirely in
C and doesn't involve the Lisp interpreter).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]