[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: calwf

From: Uwe Brauer
Subject: Re: calwf
Date: Wed, 13 Jan 2016 17:42:51 +0000
User-agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/25.0.50 (gnu/linux)

>>> "Stefan" == Stefan Monnier <address@hidden> writes:

   > In both cases (calwf and weekly-view), I expect that the issue is a
   > simple question of renaming of a few functions/variables, or some
   > such.

I had to introduce the following alias:

(defalias 'view-diary-entries 'diary-view-entries) ;which was even
obsolete in the diary-lib version of xemacs

But also 

(defalias 'general-holidays 'holiday-general-holidays)
(defalias 'oriental-holidays 'holiday oriental-holidays)
(defalias 'local-holidays 'holiday-local-holidays)
(defalias 'other-holidays  'holiday-other-holidays)
(defalias 'hebrew-holidays 'holiday-oriental-holidays)
(defalias 'christian-holidays 'holiday-christian-holidays)
(defalias 'islamic-holidays 'holiday-iclamic-holidays)

Because of the  the following ChangeLog entry

| commit 3f65970414538063e38ada2a47cb4ef4f35b630e
| Author: Glenn Morris <address@hidden>
| Date:   Sun Oct 5 19:02:04 2014 -0700
|     Remove calendar code obsolete since at least version 23.1
| * lisp/calendar/holidays.el (general-holidays, oriental-holidays)
|     (local-holidays, other-holidays, hebrew-holidays)

Frankly the rationale of renaming functions is beyond me, since it
breaks backwards compatibility.

   > Usually issues of compatibility between emacsen are fairly simple
   > to solve. E.g. the "nice display" in weekly-view in XEmacs might be
   > due simply to the fact that when the code was written it used
   > features not available in Emacs, so the author put a (featurep
   > 'xemacs) test in it. In that

He did not!

   > case, removing the test might actually be sufficient to get the
   > feature working, tho in most cases, this will bump into some
   > further compatibility issues.

   > IOW, these should all be fairly easy to debug by single-stepping
   > through the code and comparing where the execution diverges between
   > the two different emacsen.

Right. I will try that. My favorite debugging tool is edebug. Is there
anything better around now you could recommend?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]