help-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: kill-region defadvice


From: Nikolaj Schumacher
Subject: Re: kill-region defadvice
Date: Sun, 08 Jun 2008 21:56:25 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (darwin)

Kevin Rodgers <address@hidden> wrote:

> Nikolaj Schumacher wrote:
>> Joe <address@hidden> wrote:
>>
>>> Originally I did this by writing a new function that checked
>>> if the mark was active. However, I think that using defadvice is a
>>> better solution but I got stuck while trying to write it.
>>
>> No, it's not!  By using advice, you modify the kill-region function and
>> risk that any command using it will backward-kill-word instead.
>
> Just write the advice as
>
>    (if (and (interactive-p) mark-active)
>        ad-do-it
>      (backward-kill-word 1))

Still not a good idea.
`interactive-p' will return nil when used in a keyboard macro.  That
will most likely cause unintended behavior at some point.


regards,
Nikolaj Schumacher




reply via email to

[Prev in Thread] Current Thread [Next in Thread]