This code:
(add-to-list 'load-path
(expand-file-name
"/usr/share/emacs21/site-lisp/emacs-goodies-el"))
is wrong
And this one as Peter told you is wrong also:
(require 'emacs-goodies)
You have to add to load-path a directory and not a file
/usr/share/emacs21/site-lisp/emacs-goodies-el
is a directory containing the file (symlink):
emacs-goodies-el.el
You have to require a name of file without the extension (what is in
provide at the end of this file) and not a directory.
this made it work:
(require 'emacs-goodies-el)
instead of:
(require 'emacs-goodies)