help-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs 21 and w3 on Debian


From: Thierry Emery
Subject: Re: Emacs 21 and w3 on Debian
Date: Thu, 26 May 2005 12:11:03 +0200
User-agent: T-gnus/6.17.3 (based on No Gnus v0.3) SEMI/1.14.6 (Maruoka)FLIM/1.14.7 (Sanjō) APEL/10.6 Emacs/22.0.50 (gnu/linux) MULE/5.0 (SAKAKI)

I wrote:

> Klaus Straubinger <address@hidden> writes:
>
>> Wouldn't it be more correct to replace the first argument of
>> url-callback-arguments with the redirect-uri if there are any
>> such callback arguments present? I have experienced problems
>> with your solution that went away with this improvement.
>
> Through looking at the code, i thought that i had chosen the most
> cautious alternative, but it seems that i was wrong ...

Ok, i have taken a much better look at the different places in Debian
`sid' GNU Emacs 21.4 in which there are calls to `url-retrieve' and
found out that my bogus patch caused problems in
`w3-maybe-start-image-download' and
`w3-maybe-start-background-image-download',
but also in the Gnus library "nnweb.el".

I have submitted two patches for these problems to Debian:
 - the first one replaces in "url-http.el" my erroneous:
                          (list redirect-uri)
with:
                          (cons redirect-uri
                                (and url-callback-arguments
                                     (cdr url-callback-arguments)))
 - the second patch adds in "nnweb.el" `url' as first argument
   for `nnweb-callback' and as third argument in the call to
   `nnweb-url-retrieve-asynch' in `nnweb-fetch-url' (arguments used
   when calling `nnweb-callback' start with this third argument).

I have also submitted a modified patch to "url-http.el" as a follow-up
to my M-x report-emacs-bug.
The patch on "nnweb.el" is not applicable to CVS Emacs: library
"nnweb.el" does not call `url-retrieve' anymore, but uses
`mm-url-insert' instead, which calls `url-insert-file-contents'.

Finally, i have found that backporting to Emacs 21.4 the new
`url-retrieve-synchronously' from "url.el" in CVS Emacs avoids some
cases of Emacs 21.4 locking up (e.g. when a site has lots of images),
and have also submitted a patch for this to Debian.

Thanks again for pointing out my mistake,

Thierry
-- 
thierry |dot| emery |at| free |dot| fr


reply via email to

[Prev in Thread] Current Thread [Next in Thread]