[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Health-dev] MyGNUHealth: Import recordings - first test results

From: Mat Knoll
Subject: Re: [Health-dev] MyGNUHealth: Import recordings - first test results
Date: Wed, 28 Jul 2021 14:45:13 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0

Hi Luis,

great! Thanks! I'll report.


On 28.07.21 14:13, Luis Falcon wrote:
Hi, Mat

Some updates...

On Wed, 21 Jul 2021 13:36:19 +0200
Mat Knoll <> wrote:
- When (accidentally) inserting an empty row (even at the end of the
csv) an error occurred:
Traceback (most recent call last):
line 100, in parse_values
      vdate = line[0]
IndexError: list index out of range
I think now we should handle both scenarios, a true empty line (which
triggered the traceback you mentioned), and a line full of empty
columns (usually from spreadsheets)

,,,,,,,,,,, <--- EMPTY row from Libreoffice Calc

<-- Empty line

Both scenarios are now handled

One more little thing:
Typo found in header of sample_reading.csv: date(yyymmdd) - y is

I have a lot of test data that records the values individually per
column (>1500). I know this is a fundamental design aspect and
certainly there are very good reasons for the current design, however
would it be conceivable to separate the two values systolic and
diastolic by comma? Otherwise I need to write a small macro to merge
the two columns using the "/" separator. Possibly not only my import
data is stored in separate columns?
Now systolic and diastolic have their own column

When a decision is made on how to proceed, I prepare the test data
accordingly and test further cases (invalid values etc.)

I hope I was able to support. If there are any questions, please do
not hesitate to contact me.
Thank you for the testing and let me know how this second round goes :)

You can view / download the latest changesets here:

All the best

reply via email to

[Prev in Thread] Current Thread [Next in Thread]