guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#73430: [PATCH] gnu: Add guile-taglib.


From: Ludovic Courtès
Subject: bug#73430: [PATCH] gnu: Add guile-taglib.
Date: Sun, 17 Nov 2024 22:49:56 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Hi,

Alec Barreto <mrh57@posteo.net> skribis:

> * gnu/packages/guile-xyz.scm (guile-taglib): New variable.
>
> Change-Id: I68cb1945104b64f621c9e6a1689b63f66c59144e

Applied with the change below.

> Separately, is there a reason why the =guile= package doesn't have 
> "GUILE_EXTENSIONS_PATH" set in its =native-search-paths= field so that it can 
> find foreign libs?

No good reason, it should probably have that.

> The "libtag_c.so" path has to be patched here (and similar patches exist in 
> other guile packages).
> Shouldn't the "lib" dir of the profile just be added to that guile path, 
> rendering all these patches unnecessary?

Hmm yes you’re right.  I’m used to specifying absolute file names, but
just setting ‘GUILE_EXTENSIONS_PATH’ would be equally good.

Thanks,
Ludo’.

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index c4d06e10f0..044a491259 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1077,6 +1077,7 @@ (define-public guile-taglib
          (uri (git-reference
                (url "https://github.com/sbarbit/guile-taglib";)
                (commit commit)))
+         (file-name (git-file-name name version))
          (sha256
           (base32 "07z65hqxjm6rd9cdk2b9dcxj8hgz7c9dg4iprr19jrvj4ymzrbff"))))
       (build-system guile-build-system)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]