guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#62298] [PATCH v2 4/8] services: mympd: Require 'syslog service when


From: Maxim Cournoyer
Subject: [bug#62298] [PATCH v2 4/8] services: mympd: Require 'syslog service when configured to log to syslog.
Date: Fri, 24 Mar 2023 10:32:17 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Hi,

Bruno Victal <mirai@makinata.eu> writes:

> * gnu/services/audio.scm (mympd-shepherd-service): Depend on 'syslog when
> configured to log to syslog.
> ---
>  gnu/services/audio.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
> index e9ecccd614..e5b065a479 100644
> --- a/gnu/services/audio.scm
> +++ b/gnu/services/audio.scm
> @@ -749,7 +749,9 @@ (define (mympd-shepherd-service config)
>      (let ((log-level* (format #f "MYMPD_LOGLEVEL=~a" log-level)))
>        (shepherd-service
>         (documentation "Run the myMPD daemon.")
> -       (requirement `(loopback user-processes ,@shepherd-requirement))
> +       (requirement `(loopback user-processes
> +                               ,@(if (eqv? log-to 'syslog) '(syslog) '())

eq? is sufficient to compare symbols.  Otherwise, LGTM.

-- 
Thanks,
Maxim





reply via email to

[Prev in Thread] Current Thread [Next in Thread]