[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope.
From: |
Nicolas Goaziou |
Subject: |
[bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope. |
Date: |
Wed, 08 Mar 2023 16:42:53 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:
> +(define-public emacs-xcscope
Thank you. Some comments follow.
> + (package
You need to let-bind commit and revision (set to "0" initially) around
here.
> + (name "emacs-xcscope")
> + (version "1.0")
Here, you should use
(git-version "1.0" revision commit)
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/dkogan/xcscope.el")
> + (commit "d228d7593d762e457340f678d14b663ef66d7cee")))
This should be
(commit commit)
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "0pr85ywp585imjzswm04647nb4iqqvg8jgmbcs5210qmr9kh0z8d"))))
> + (build-system emacs-build-system)
You also need to add `cscope' as an input, and patch "xscope.el" so
`cscope-program' point to the proper binary, using
`emacs-substitute-variables'. See, e.g., emacs-plz package for an
example.
> + (home-page "https://github.com/dkogan/xcscope.el")
> + (synopsis "cscope interface for (X)Emacs")
cscope -> Cscope. You can also drop (X) from (X)Emacs.
> + (description
> + "cscope interface for (X)Emacs")
This should be a full sentence (with proper capitalization).
> + (license license:gpl3+)))
License is actually license:gpl2+, per headers in xscope.el file.
> ;;; Avoid adding new packages to the end of this file. To reduce the chances
> ;;; of a merge conflict, place them above by existing packages with similar
^
Hmmmmm…
Could you send an updated patch, with another location for the package
definition, and a proper commit message?
Regards,
--
Nicolas Goaziou
- [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope.,
Nicolas Goaziou <=