[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60847] [PATCH] Enable cross-compilation for the pyproject-build-sys
From: |
Ludovic Courtès |
Subject: |
[bug#60847] [PATCH] Enable cross-compilation for the pyproject-build-system. |
Date: |
Mon, 06 Mar 2023 18:04:35 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> +++ b/guix/packages.scm
> @@ -1864,28 +1864,30 @@ (define* (bag->derivation bag #:optional context)
[…]
> + (let ((builder-name (procedure-name (bag-build bag))))
> + (if (or (bag-target bag)
> + (eq? 'pyproject-build builder-name))
> + (bag->cross-derivation bag)
This one part is a showstopper to me, for two reasons:
1. We cannot rely on ‘procedure-name’ (it’s a debugging aid and it’s
not guaranteed to return something useful).
2. Special-casing build systems here is not okay: the bag and build
system abstractions exist to maintain separation of concerns.
I understand there’s an actual bug to fix and the desire to fix a more
common issue, but I think this one approach is not the way forward.
I hope that makes sense!
Ludo’.
[bug#60847] [PATCH] Enable cross-compilation for the pyproject-build-system., Ludovic Courtès, 2023/03/10