[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#61587] [PATCH 0/8] networking services refactoring
From: |
Bruno Victal |
Subject: |
[bug#61587] [PATCH 0/8] networking services refactoring |
Date: |
Fri, 3 Mar 2023 17:26:51 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 |
On 2023-03-03 17:13, Ludovic Courtès wrote:> Bruno Victal <mirai@makinata.eu>
skribis:
>
>> Supersedes #47253. (Note: Shepherd no longer blocks since shepherd 0.9.3)
>
> What does that mean?
Oops, I didn't intend to include this in the commit message, it was for the
mail body.
At the time I didn't notice that #47253 already had a patch to solve this issue
which resulted
in independent rewrite of the same fix. I only noticed it while I was searching
for open issues to
attach to the message as potential issues that would be closed by this.
The note refers to what made #47253 untenable back then.
>> * gnu/services/networking.scm (network-manager-shepherd-service): Await for
>> NetworkManager to finish starting up.
>
> [...]
>
>> + (start
>> + #~(lambda args
>> + (let ((constructor
>> + (apply
>> + (make-forkexec-constructor
>> + (list #$(file-append network-manager
>> + "/sbin/NetworkManager")
>> + (string-append "--config=" #$conf)
>> + "--no-daemon")
>
> Rather:
>
> (let ((pid (fork+exec-command (list …))))
> …
> pid)
I'll send a v2 with the required touch-ups.
Cheers,
Bruno