[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#56213] [PATCH] gnu: Add maven-doxia-core

From: Artyom V. Poptsov
Subject: [bug#56213] [PATCH] gnu: Add maven-doxia-core
Date: Sat, 25 Jun 2022 15:14:58 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Hello Julien.

> Thanks for the patch!

Thanks for taking your time for reviewing my patch.  :-)

> Missing full stop at the end of the subject line.

Okay, added a full-stop.

FWIW, I'm usually following those rules when writing commit messages:

The rules explicitly say that a committer should not add a full-stop at
the end of the first line.

> This package actually has tests, could you enable them?

Unfortunately tests require JUnit5.  :-/

> The pom file references most of these as runtime dependencies, so we
> need to propagate them, so maven can find them.

> We also need to propagated the parent pom :)


However, 'guix lint' gave me the following warning:
--8<---------------cut here---------------start------------->8---
maven-doxia-core@2.0.0-M2: propagated inputs plexus-parent-pom@5.1 and 
plexus-parent-pom@4.0 collide
--8<---------------cut here---------------end--------------->8---

I don't know yet how to properly fix that; probably the issue is that I
made all the inputs propagated, but I don't see how to differentiate
them looking at the Doxia Core 'pom.xml'.

> This feels like a description of the whole Doxia project. Could you add
> maybe one sentence to explain how this package is related to the whole
> doxia project?


> Lastly, I would put this package just below maven-doxia-parent-pom, but
> that's mostly aesthetic :)


Please find the updated patch attached.

Attachment: 0001-gnu-Add-maven-doxia-core.patch
Description: Text Data

- Artyom

Artyom "avp" Poptsov <>
Home page:
CADR Hackerspace co-founder:
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]