[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56075: [PATCH 0/2] Report location of invalid configuration field va
bug#56075: [PATCH 0/2] Report location of invalid configuration field values
Fri, 24 Jun 2022 23:43:50 +0200
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
Maxim Cournoyer <email@example.com> skribis:
> Very nice! I had been meaning to look at what define-configure could be
> improved w.r.t. the recently added sanitizers; I felt perhaps
> `define-configure' would perhaps loose its relevance, but I'm happy to
> see you saw value in upgrading it!
Yeah, the mechanism that ‘define-configuration’ had had become
> The first part LGTM, although I so rarely dabble with syntax-case that
> it looks a bit alien to my eyes now.
Well, ‘define-configuration’ is a bit hairy. :-)
>> +++ b/tests/services/configuration.scm
>> @@ -19,6 +19,7 @@
> You forgot to add your copyright notice line.
>> +(test-equal "wrong type for a field"
>> + '("configuration.scm" 56 11) ;error location
>> + (guard (c ((configuration-error? c)
>> + (let ((loc (error-location c)))
>> + (list (basename (location-file loc))
>> + (location-line loc)
>> + (location-column loc)))))
>> + (port-configuration
>> + ;; This is line 55; the test relies on line/column numbers!
>> + (port "This is not a number!"))))
> It seems fragile to rely on the line/column number, but if we truly need
> to test that, I don't see a better options.
Yeah; there is another option, which is to read code from a string port
and to simulate its location, but it’s more lines of code for little
6505f727e1 services: configuration: Remove 'validate-configuration'.
fb7e6ccba7 services: configuration: Report the location of field type errors.