[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#55929] [PATCH] gnu: maven: Add maven-doxia-sink-api

From: Julien Lepiller
Subject: [bug#55929] [PATCH] gnu: maven: Add maven-doxia-sink-api
Date: Sat, 18 Jun 2022 20:00:13 +0200

Thanks for the new patch :)

Le Sat, 18 Jun 2022 19:57:15 +0300,
"Artyom V. Poptsov" <> a écrit :

> +    (native-inputs
> +     (list java-javax-inject))
> +    (propagated-inputs
> +     (list maven-parent-pom-34))

Sorry if my previous messages were confusing you. I meant to have a new
package maven-doxia-parent (or similar name) that contains only the
parent pom file. You're propagating the grand-parent. I think this
would be more correct:

(propagated-inputs (list maven-doxia-parent))

and maven-doxia-parent would be something like:

(define maven-doxia-parent
    (inherit maven-doxia-sink-api)
    (name "maven-doxia-parent")
     `(#:tests? #f
       (modify-phases %standard-phases
         (delete 'configure)
         (delete 'build)
         (replace 'install (install-pom-file "pom.xml")))))
    (synopsis "...")
    (description "...")))

This is untested, of course :)

Since we "define" and not "define-public" (we don't want it to be
accessible from other modules or the command-line), you can put both
packages in the same patch.

> +    (arguments
> +     `(#:jar-name "doxia-sink-api.jar"
> +       #:source-dir "doxia-sink-api/src/main/java"
> +       #:tests? #f ; no tests
> +       #:phases (modify-phases %standard-phases
> +                  (replace 'install
> +                    (install-from-pom "doxia-sink-api/pom.xml")))))

That's correct :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]