[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#55922] [PATCH] gnu: Add guile-termios.
From: |
Ludovic Courtès |
Subject: |
[bug#55922] [PATCH] gnu: Add guile-termios. |
Date: |
Thu, 16 Jun 2022 23:15:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi Antero,
Looks like we’re almost done; some comments inline below.
Antero Mejr <antero@mailbox.org> skribis:
> * gnu/packages/guile-xyz.scm (guile-termios): New variable.
Note that all the relevant variables should be listed here.
> +(define-public guile2.0-termios
> + (package
> + (inherit guile-termios)
> + (name "guile2.0-termios")
> + (native-inputs (list guile-2.0))))
> +
> +(define-public guile2.2-termios
> + (package
Unless there really is a need for them, you can drop them. It’s
reasonable to assume 3.0 as the default for new code.
> +(define-public guile-tap
> + (package
> + (name "guile-tap")
> + (version "0.4.6")
Could you make it a separate patch, and also remove the 2.0/2.2
variants?
By convention we usually add one package per patch:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
Thanks in advance!
Ludo’.