[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#55693] [PATCH v2 2/2] gnu: Add gitlint.
From: |
Maxime Devos |
Subject: |
[bug#55693] [PATCH v2 2/2] gnu: Add gitlint. |
Date: |
Thu, 02 Jun 2022 01:04:30 +0200 |
User-agent: |
Evolution 3.38.3-1 |
Brian Kubisiak schreef op ma 30-05-2022 om 16:17 [-0700]:
> + #t)))))
Trailing #t aren't required anymore since a long time, it can be
removed.
> + (inputs
> + `(("git" ,git)
> + ("python-arrow" ,python-arrow)
> + ("python-click" ,python-click)
> + ("python-sh" ,python-sh)))
Input labels aren't required anymore. Try running "guix style -S
inputs". Also, IIUC, Hartmut Goebel would prefer not using quasiquote
(`):
(arguments
(list #:phases
#~(modify-phases [stuff]
[stuff]
...)))
to avoid the complicated quasiquote/unquote construct, with which I
agree though it's AFAIK not (yet?) elevated to ‘official Guix style’ or
such.
Otherwise LGTM, though I haven't looked at most of the source code of
gitlint (for malware or such) or in detail at the description and
synopsis (for clarity and such).
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
- [bug#55693] [PATCH v2 2/2] gnu: Add gitlint.,
Maxime Devos <=