[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48463] gnu: Add j.
From: |
elaexuotee |
Subject: |
[bug#48463] gnu: Add j. |
Date: |
Wed, 12 Jan 2022 21:07:45 +0900 |
User-agent: |
mblaze/1.1 |
> > + `(#:tests? #f
> > [...]
> > + (replace 'check
> > + (lambda* (#:key tests? #:allow-other-keys)
> > + (when tests? [...]))))
>
> I think #:tests? #false should be removed, otherwise this
> check phase would never do anything.
Nice catch! Thanks. Disabled tests when tweaking builds and forgot to remove.
> > + ;; The jlibrary/dev directory only sometimes exists,
> > but needs
> > + ;; to be copied into the ~system directory when it
> > does.
> > + (for-each
> > + (lambda (dev-dir)
> > + (if (access? dev-dir R_OK)
> > + (copy-recursively dev-dir
> > "test/bin/system/dev")))
>
>
> Are you testing for file permissions, or for the existence of the file?
> If the latter, I'd recommend using 'file-exists?' instead.
>
> > + (if (access? source-dev R_OK)
Just existence. Thanks for the pointer. Changed.
0001-gnu-Add-j.patch
Description: Text Data
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/12
- [bug#48463] gnu: Add j., Maxime Devos, 2022/01/12
- [bug#48463] gnu: Add j., Maxime Devos, 2022/01/12
- [bug#48463] gnu: Add j.,
elaexuotee <=
- [bug#48463] gnu: Add j., Liliana Marie Prikler, 2022/01/12
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/13
- [bug#48463] gnu: Add j., Liliana Marie Prikler, 2022/01/13
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/15
- [bug#48463] gnu: Add j., Liliana Marie Prikler, 2022/01/15
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/16
- [bug#48463] gnu: Add j., Liliana Marie Prikler, 2022/01/16
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/16
- [bug#48463] gnu: Add j., Liliana Marie Prikler, 2022/01/16
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/16