[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add
From: |
Pierre Langlois |
Subject: |
[bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp. |
Date: |
Tue, 23 Nov 2021 20:54:26 +0000 |
User-agent: |
mu4e 1.6.10; emacs 27.2 |
Hi Timothy,
Timothy Sample <samplet@ngyro.com> writes:
> Hi Philip,
>
> There are some really valuable changes in here, thanks! I would like to
> start understanding and reviewing the changes so that we can get some of
> this good stuff merged in. However, I have one question that I couldn’t
> answer from reading here or at <https://issues.guix.gnu.org/49946>: is
> there an agreement between you and Pierre that these patches are the
> “right” way to do native addons for Node.js. More importantly, is the
> general plan that we merge these changes, and then Pierre rebases their
> Tree-sitter changes on top these?
>
> Pierre, maybe you could weigh in here?
The overall approach looks good to me, it's better than what I
originally proposed for sure :-). That being said, I'm not very
familiar with the Node.js ecosystem so I don't know if it's necessarily
the right way, but I suspect the correct way for node isn't very Guix-y
so I'm not too worried about that.
It's on my TODO list to take another look at the patches as well :-),
then yes, I'm planning on rebasing my tree-sitter series on top.
> Sorry if I missed something. I assume everything is OK, but I want to
> be sure before I start digging into the details of the patches –
> especially those first few more complicated ones. :)
Thanks for taking a look!
Pierre
signature.asc
Description: PGP signature
- [bug#51838] [PATCH 05/11] gnu: Add node-safe-buffer., (continued)
- [bug#51838] [PATCH 05/11] gnu: Add node-safe-buffer., Philip McGrath, 2021/11/14
- [bug#51838] [PATCH 07/11] gnu: Add node-readable-stream., Philip McGrath, 2021/11/14
- [bug#51838] [PATCH 04/11] gnu: Add node-inherits., Philip McGrath, 2021/11/14
- [bug#51838] [PATCH 09/11] gnu: Add node-openzwave-shared., Philip McGrath, 2021/11/14
- [bug#51838] [PATCH 06/11] gnu: Add node-string-decoder., Philip McGrath, 2021/11/14
- [bug#51838] [PATCH 08/11] gnu: Add node-nan., Philip McGrath, 2021/11/14
- [bug#51838] [PATCH 10/11] gnu: Add node-addon-api., Philip McGrath, 2021/11/14
- [bug#51838] [PATCH 11/11] gnu: Add node-sqlite3., Philip McGrath, 2021/11/14
- [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp., Timothy Sample, 2021/11/20
- [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp., Timothy Sample, 2021/11/20
- [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp.,
Pierre Langlois <=
- [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp., Timothy Sample, 2021/11/20
- [bug#51838] [PATCH v2 04/26] gnu: node: Add an npmrc file to set nodedir., Timothy Sample, 2021/11/20