[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49533] [PATCH] gnu: Add omins-lv2.
From: |
Ludovic Courtès |
Subject: |
[bug#49533] [PATCH] gnu: Add omins-lv2. |
Date: |
Thu, 29 Jul 2021 21:53:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi Thorsten,
Thorsten Wilms <t_w_@freenet.de> skribis:
> * gnu/packages/audio.scm (omins-lv2): New variable.
It LGTM, modulo minor issues:
> +(define-public omins-lv2
> + (package
> + (name "omins-lv2")
Please consider passing it through ./etc/indent-code.el:
https://guix.gnu.org/manual/en/html_node/Formatting-Code.html
> + ;; No release despite being perfectly usable. 0.0.0 seems to be the only
> + ;; version the author ever specified:
> + (version "0.0.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://git.drobilla.net/cgit.cgi/omins.lv2.git/")
> + (commit "058f341053067b69a84d4081107fda5058290ff9")))
Please check out
<https://guix.gnu.org/manual/en/html_node/Version-Numbers.html> on how
to compute version numbers in such cases.
> + (native-search-paths
> + (list (search-path-specification
> + (variable "LV2_PATH")
> + (files '("lib/lv2")))))
I’m surprised this is here (in the plugin) rather than in the package
that loads this plugin. There are other LV2 plugins doing that though.
Ricardo, WDYT?
> + (license (list license:gpl2+ license:gpl2+))))
(license license:gpl2+) should be enough. :-)
Could you send an updated patch?
Thank you, and thanks, Sarah!
Ludo’.