[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49705] [PATCH] gnu: gmnisrv: Fix configure flags.
From: |
Arun Isaac |
Subject: |
[bug#49705] [PATCH] gnu: gmnisrv: Fix configure flags. |
Date: |
Sun, 25 Jul 2021 19:53:45 +0530 |
Hi Sarah,
Thank you for improving our gmnisrv package!
> + #:make-flags '("CC=gcc")))
This should be (list (string-append "CC=" ,(cc-for-target))) so that the
package cross-compiles correctly. Hard-coding CC=gcc is now deprecated
practice.
I also feel that this patch should be split into at least two patches or
maybe even three. This way, the first line summary in the commit message
is much more descriptive of the change.
1. gnu: gmnisrv: Remove dependency on /etc/mime.types.
2. gnu: gmnisrv: Cross-compile.
3. gnu: gmnisrv: Disable tests using tests?.
WDYT? Feel free to combine patches 2 and 3 if that splitting is a bit
excessive.
Thanks,
Arun
signature.asc
Description: PGP signature
- [bug#49705] [PATCH] gnu: gmnisrv: Fix configure flags., Sarah Morgensen, 2021/07/23
- [bug#49705] [PATCH] gnu: gmnisrv: Fix configure flags.,
Arun Isaac <=
- [bug#49705] [PATCH v2 0/4] gnu: gmnisrv: Fix configure flags., Sarah Morgensen, 2021/07/25
- [bug#49705] [PATCH v2 1/4] gnu: gmnisrv: Disable tests using #:tests?., Sarah Morgensen, 2021/07/25
- [bug#49705] [PATCH v2 3/4] gnu: gmnisrv: Remove dependency on /etc/mime.types., Sarah Morgensen, 2021/07/25
- [bug#49705] [PATCH v2 2/4] gnu: gmnisrv: Use #:make-flags, and cross-compile., Sarah Morgensen, 2021/07/25
- [bug#49705] [PATCH v2 4/4] gnu: gmnisrv: Fix configuration search path., Sarah Morgensen, 2021/07/25
- bug#49705: [PATCH v2 0/4] gnu: gmnisrv: Fix configure flags., Arun Isaac, 2021/07/26